This repository was archived by the owner on Mar 10, 2020. It is now read-only.
refactor: convert object.* and files.* API methods to async/await#1160
Merged
refactor: convert object.* and files.* API methods to async/await#1160
Conversation
alanshaw
changed the title
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
force-pushed
the
refactor/object-and-files-async-await
branch
from
1ebd7c8 to
b7b4a91
Compare
alanshaw
changed the title
added 2 commits
November 19, 2019 22:47
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
changed the title
hugomrdias
approved these changes
Nov 20, 2019
| @@ -27,7 +28,7 @@ module.exports = create => config => { | |||
| // https://github.com/sindresorhus/ky/pull/153 | |||
Contributor
There was a problem hiding this comment.
do we still need this ? its been merged
Contributor
Author
There was a problem hiding this comment.
This is not the PR I thought it was, it still gets fetch off the global object so we can't pass a custom fetch implementation. This comment should just be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also allows the
timeoutoption to be passed as a human readable string, which is compatible with thego-ipfsglobaltimeoutoption.Depends on: